Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove podiatry from type of care list #32980

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Remove podiatry from type of care list #32980

merged 7 commits into from
Nov 13, 2024

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Nov 12, 2024 •
edited
Loading

Summary

This removes/hides Podiatry from the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature flag is true.

Related issue(s)

department-of-veterans-affairs/va.gov-team#95332

Testing done

  • Local testing
  • e2e testing
  • Unit testing

Screenshots

With vaOnlineSchedulingRemovePodiatry set to false

localhost_3001_my-health_appointments_($small-screen)

With vaOnlineSchedulingRemovePodiatry set to true

localhost_3001_my-health_appointments_schedule_type-of-care($small-screen)

Acceptance criteria

Podiatry should not be shown as an option on the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature is set to true.

Podiatry should be shown as an option on the Type of Care page when the vaOnlineSchedulingRemovePodiatry feature is set to false and the CC flag is on.

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Screenshot of the developed feature is added

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@ryanshaw
Moves tests
216a6bf 
Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw
Tied in vaOnlineSchedulingRemovePodiatry feature flag to selectors an…
b05240c 
…d type of care page

Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw
Adds test
e2d99fe 
Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw ryanshaw self-assigned this Nov 12, 2024
ryanshaw
ryanshaw commented Nov 12, 2024
View reviewed changes
src/applications/vaos/new-appointment/redux/selectors.js
@@ -373,6 +374,7 @@ export function selectTypeOfCarePage(state) {
pageChangeInProgress: selectPageChangeInProgress(state),
showCommunityCare: selectFeatureCommunityCare(state),
showDirectScheduling: selectFeatureDirectScheduling(state),
removePodiatry: selectFeatureRemovePodiatry(state),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the removePodiatry variable name here as all of the other variables are showSomething but wanted to keep it consistent with what the feature flag was originally named.

ryanshaw
ryanshaw commented Nov 12, 2024
View reviewed changes
src/applications/vaos/new-appointment/components/TypeOfCarePage/index.jsx
typeOfCare => typeOfCare.id !== PODIATRY_ID || showCommunityCare,
typeOfCare =>
typeOfCare.id !== PODIATRY_ID ||
(showCommunityCare && !removePodiatry),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the removePodiatry variable name here as all of the other variables are showSomething but wanted to keep it consistent with what the feature flag was originally named.

@ryanshaw
Updated test title to make consistent
1bd14a0 
Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw
Merge branch 'main' of github.com:department-of-veterans-affairs/vets…
46fd2e8 
…-website into ryanshaw/95332-remove-podiatry-from-type-of-care-list
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/95332-remove-podiatry-from-type-of-care-list/main November 12, 2024 15:10 Inactive
@ryanshaw
Fixes test
aeff7a0 
Signed-off-by: Ryan Shaw <[email protected]>
@ryanshaw ryanshaw marked this pull request as ready for review November 12, 2024 16:42
@ryanshaw ryanshaw requested review from a team as code owners November 12, 2024 16:42
rmessina1010
rmessina1010 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanshaw ryanshaw merged commit 5e1dd7b into main Nov 13, 2024
76 of 79 checks passed
@ryanshaw ryanshaw deleted the ryanshaw/95332-remove-podiatry-from-type-of-care-list branch November 13, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmessina1010 rmessina1010 rmessina1010 approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo JunTaoLuo is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe

@vbahinwillit vbahinwillit Awaiting requested review from vbahinwillit vbahinwillit is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe

@simiadebowale simiadebowale Awaiting requested review from simiadebowale simiadebowale is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe

Assignees

@ryanshaw ryanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanshaw @rmessina1010 @va-vfs-bot